fix(PlotMapView): default to all layers in plot_pathline() #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaulting to layer 0 for arrays where each cell is assigned a color is sensible but imo it is more natural to plot complete pathlines by default
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2242 +/- ##
=========================================
- Coverage 73.9% 67.8% -6.2%
=========================================
Files 294 294
Lines 58886 58868 -18
=========================================
- Hits 43575 39929 -3646
- Misses 15311 18939 +3628
|
langevin-usgs
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaulting to layer 0 for arrays where each cell is assigned a color is sensible but for pathlines it seems more natural to include all layers for complete pathlines. This might (pragmatically) be seen as a bugfix rather than a breaking change?