Skip to content

Comments

fix(mp7particledata): add global_xy to to_prp#2405

Merged
wpbonelli merged 3 commits intomodflowpy:developfrom
dbrakenhoff:to_prp_add_global_xy_flag
Dec 23, 2024
Merged

fix(mp7particledata): add global_xy to to_prp#2405
wpbonelli merged 3 commits intomodflowpy:developfrom
dbrakenhoff:to_prp_add_global_xy_flag

Conversation

@dbrakenhoff
Copy link
Contributor

@dbrakenhoff dbrakenhoff commented Dec 23, 2024

  • default is False which converts vertices to model coordinates
  • add simple test

Note: method does get slow when it has to do the vertices conversion for lots of points. This can undoubtedly be optimized by first computing vertices in model coordinates or something along those lines. But I figured that was outside the scope for this PR.

- default is False which converts vertices to model coordinates
- add simple test
- default is False which converts vertices to model coordinates
- add simple test
@dbrakenhoff dbrakenhoff self-assigned this Dec 23, 2024
@dbrakenhoff dbrakenhoff linked an issue Dec 23, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.4%. Comparing base (bb9824e) to head (b9ce6b0).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/modpath/mp7particledata.py 80.0% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2405     +/-   ##
=========================================
+ Coverage     68.4%   76.4%   +7.9%     
=========================================
  Files          294     294             
  Lines        59390   59712    +322     
=========================================
+ Hits         40652   45624   +4972     
+ Misses       18738   14088   -4650     
Files with missing lines Coverage Δ
flopy/modpath/mp7particledata.py 88.4% <80.0%> (-0.5%) ⬇️

... and 245 files with indirect coverage changes

Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@wpbonelli wpbonelli merged commit 942a4cd into modflowpy:develop Dec 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ParticleData.to_prp() returns global coordinates

2 participants