Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(get-modflow): don't hard-code available os tags #2426

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

wpbonelli
Copy link
Member

Since these are given to change, it seems sufficient to raise (as we do) if a corresponding asset doesn't exist.

Since these are given to change, it seems sufficient to raise (as we do) if it doesn't exist.
@wpbonelli wpbonelli requested a review from mwtoews January 26, 2025 05:42
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.3%. Comparing base (bb9824e) to head (347abe6).
Report is 41 commits behind head on develop.

Files with missing lines Patch % Lines
flopy/utils/get_modflow.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2426     +/-   ##
=========================================
+ Coverage     68.4%   76.3%   +7.8%     
=========================================
  Files          294     294             
  Lines        59390   59875    +485     
=========================================
+ Hits         40652   45704   +5052     
+ Misses       18738   14171   -4567     
Files with missing lines Coverage Δ
flopy/utils/get_modflow.py 63.6% <0.0%> (+37.3%) ⬆️

... and 247 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review January 26, 2025 17:08
Copy link
Contributor

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this should not be hard-coded.

And on that topic, conda/pixi have different platform specifiers like win-64, linux-64, osx-64, osx-arm64, etc., the compete list is here.

@wpbonelli wpbonelli merged commit 6a8f313 into modflowpy:develop Jan 26, 2025
23 checks passed
@wpbonelli wpbonelli deleted the get-modflow branch January 26, 2025 21:37
@wpbonelli
Copy link
Member Author

And on that topic, conda/pixi have different platform specifiers like win-64, linux-64, osx-64, osx-arm64, etc., the compete list is here.

Thanks for this, I had wondered whether there was a standard. It would make sense to use the same for our releases, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants