support custom user model without user groups #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no user groups exist, don't query it, so that when you use a custom user model without groups, that you don't get an error. Relevant GitHub Issue: modlinltd#57
asfaltboy
requested changes
Jan 24, 2022
Member
asfaltboy
left a comment
asfaltboy
left a comment
There was a problem hiding this comment.
Could you kindly add a test case for this scenario?
Also, please rebase over master to re-run the updated CI tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no user groups exist, don't query it, so that when you use a custom
user model without groups, that you don't get an error.
Relevant GitHub Issue: #57