[driver] Implement QMC5883L driver#1063
Merged
salkinium merged 1 commit intomodm-io:developfrom Sep 11, 2023
Merged
Conversation
salkinium
requested changes
Sep 2, 2023
mbait
force-pushed
the
develop
branch
2 times, most recently
from
bbfbd9d to
c6babef
Compare
Contributor
Author
|
Addressed all the issues. |
salkinium
requested changes
Sep 4, 2023
Member
salkinium
left a comment
salkinium
left a comment
There was a problem hiding this comment.
Please change the file endings for consistency and since I'm not entirely sure if all our tooling works correctly with .cc/.hh file endings.
mbait
force-pushed
the
develop
branch
2 times, most recently
from
b193a94 to
289b248
Compare
Member
|
Could you synchronize the documentation in the README and rebase on the latest develop branch? |
salkinium
approved these changes
Sep 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QMC5883L is a cheap Chinese implementation of HMC5883L which sought its popularity in DIY Arduino-based projects. Despite the very similar name QMC5883L share almost no common bits with HMC5883L - the register map and the logic vary a lot, so it would be not feasible to re-use the existing driver. The datasheet can be found at https://datasheet.lcsc.com/szlcsc/QST-QMC5883L-TR_C192585.pdf
Even though the chip can barely be considered for use in a serious project (in my humble opinion), people seeking to leave Arduino foundation for something more serious might benefit from this driver. Like I was looking for a way to squize maximal throughput out of that chip for which a non-blocking i2c implementation must be present.