Refactor IWDG driver and add initialize function for prescaler with downcounter #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salkinium
commented
Jan 21, 2024
salkinium
force-pushed
the
feature/init_iwdg_by_time
branch
from
055da7b to
3dc8cd8
Compare
salkinium
force-pushed
the
feature/init_iwdg_by_time
branch
3 times, most recently
from
1654c8b to
c0f5bbf
Compare
salkinium
force-pushed
the
feature/init_iwdg_by_time
branch
from
c0f5bbf to
2dc6769
Compare
|
Great, I messed up and merged this accidentally while rebasing. Fantastic… |
|
There's no way to open a merged PR, unlike closed PRs, so I'll address the review in a separate PR on the weekend. Damn it. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this escalated a little. I was just looking through the code and saw that the Iwdg class was not inlined, so I quickly refactored it and then noticed that the prescaler was manually computed and then I had to program a constexpr algorithm for it.
modm::platformnamespace.Rcc::LsiandRcc::Hsiclock.modm.digsepfilter for nicely formatting long integers.SystemClock::Iwdgto every board.assertBaudrateInToleranceimplementation.seconds_t,milliseconds_t,microseconds_tfor template parameters.percent_tcan be float since C++20.