Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fatal error on php8 when cleaning up records #12

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

Mark-H
Copy link
Member

@Mark-H Mark-H commented Apr 11, 2023

Untested

Fatal error: Uncaught TypeError: date(): Argument #2 ($timestamp) must be of type ?int, string given in core/components/akismet/src/Akismet.php:301 Stack trace: #0 /home/clients/fa26d812a5cb82deda0e9bbc2e8f843f/web/core/components/akismet/src/Akismet.php(301): date('Y-m-d H:i:s', '2023-03-12 11:2...')

https://secure.helpscout.net/conversation/2209997401/35434?folderId=46279

Fatal error: Uncaught TypeError: date(): Argument #2 ($timestamp) must be of type ?int, string given in core/components/akismet/src/Akismet.php:301 Stack trace: #0 /home/clients/fa26d812a5cb82deda0e9bbc2e8f843f/web/core/components/akismet/src/Akismet.php(301): date('Y-m-d H:i:s', '2023-03-12 11:2...') 

https://secure.helpscout.net/conversation/2209997401/35434?folderId=46279
@Mark-H Mark-H requested a review from muzzwood April 11, 2023 15:08
Copy link
Collaborator

@muzzwood muzzwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected 👍🏻

@muzzwood muzzwood merged commit 5890375 into master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants