feat: start of cross platform page system #4731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMB11
changed the title
IMB11
commented
Nov 10, 2025
|
|
||
| import { defineNuxtPlugin, useState } from '#imports' | ||
|
|
||
| export default defineNuxtPlugin((nuxt) => { |
Member
Author
There was a problem hiding this comment.
Ideally we just stop using useAsyncData entirely and focus on this for now - migrating as needed.
IMB11
commented
Nov 10, 2025
| ...generatedState, | ||
| } | ||
|
|
||
| const [ |
Member
Author
There was a problem hiding this comment.
Moved to api-client, see notion, we need to figure out how we're going to do this (the full thing, not just tags) for the app-frontend.
IMB11
commented
Nov 10, 2025
|
|
||
| export interface GeneratedState extends Labrinth.State.GeneratedState { | ||
| // Additional runtime-defined fields not from the API | ||
| projectTypes: ProjectType[] |
Member
Author
There was a problem hiding this comment.
see other comment, how are we going to handle this on app-frontend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this is only going to be used by the servers pages, but I dont see why we cant use this for orgs, users, collections etc.? Out of scope though
@tanstack/vue-querywhich is a cross platformuseAsyncDataalternative - this will only be used in the@modrinth/uipackage and potentially the app frontend in the future?Set up a system inside of@modrinth/uifor automatic page registration on nuxt + app frontend@modrinth/ui.Places to look:
packages/ui/src/pages- I tried to make a dynamic page system, however i was running into issues with nuxt, so I think it's probably just easier to just create stubs on the frontend, this isn't great... For the app-frontend we can just pass the page from@modrinth/uiinto the route object in the routes.js, which is good.packages/ui/src/pages/servers/manage/index.vue- Take a look at tanstack query, it's a cross platform useAsyncData alternative (that's actually better in most cases) - read more: https://tanstack.com/query/latest/docs/framework/vue/overviewpackages/ui/src/providers/api-client.ts- abstracted