Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Commit

Permalink
Fix ambiguous default export (#113)
Browse files Browse the repository at this point in the history
Currently Omorphia's index file has both the default and named exports.
While this is totally supported by native ESM, it's pretty hard for
transpilers to process and may lead to situations where named exports
cannot be imported directly, requiring destructuring on the default
import. For this and just consistency reasons, you'd usually avoid
mixing default and named exports.

This commit removes the default export, making it just an another named
export called `plugin`.

BREAKING CHANGE: plugin is now exported using `plugin` export, rather
than the default export.
  • Loading branch information
brawaru authored Nov 13, 2023
1 parent 06d6cb6 commit 5051ad9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/.vitepress/theme/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { localeDefinitions } from '@modrinth/omorphia-dev/locales/index.js'
import { createPlugin } from '@vintl/vintl/plugin'
import Omorphia from 'omorphia'
import { plugin as Omorphia } from 'omorphia'
import DefaultTheme from 'vitepress/theme'
import { createVNode } from 'vue'
import DemoContainer from './DemoContainer.vue'
Expand Down
3 changes: 1 addition & 2 deletions lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import * as components from './components/index.js'
import FloatingVue from 'floating-vue'
import { Plugin } from 'vue'

const plugin: Plugin = (app) => {
export const plugin: Plugin = (app) => {
for (const key in components) {
app.component(key, components[key as keyof typeof components])
}
app.use(FloatingVue)
}

export default plugin
export * from './components/index.js'
export * from './helpers/index.js'

Expand Down

0 comments on commit 5051ad9

Please sign in to comment.