This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Make Omorphia an ESM-only module #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESM is widely supported these days and continues to improve. All intended Omorphia consumers do not use CJS export, as such it is unnecessary and can be safely removed to speed up the build process and remove the possibility of the dual package hazard. Third-party consumers recommended to switch to ESM or use async import. Recommended read: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
triphora
approved these changes
Nov 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM is widely supported these days and continues to improve. All
intended Omorphia consumers do not use CJS export, as such it is
unnecessary and can be safely removed to speed up the build process
and remove the possibility of the dual package hazard.
Third-party consumers recommended to switch to ESM or use async import.
Recommended read:
https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c