Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid filtering refactor for improved accuracy and persistence via URL parameters #16369

Merged
merged 47 commits into from
Feb 10, 2024

Base class updates

334d553
Select commit
Loading
Failed to load commit list.
Merged

Grid filtering refactor for improved accuracy and persistence via URL parameters #16369

Base class updates
334d553
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 10, 2024 in 0s

21.58% (-0.16%) compared to 8feb62f

View this Pull Request on Codecov

21.58% (-0.16%) compared to 8feb62f

Details

Codecov Report

Attention: 328 lines in your changes are missing coverage. Please review.

Comparison is base (8feb62f) 21.73% compared to head (334d553) 21.58%.
Report is 57 commits behind head on 3.x.

Files Patch % Lines
core/src/Revolution/modLexicon.php 25.00% 78 Missing ⚠️
.../Processors/Workspace/PackageNamespace/GetList.php 0.00% 68 Missing ⚠️
...Revolution/Processors/System/Settings/GetAreas.php 0.00% 50 Missing ⚠️
...rocessors/Element/Template/TemplateVar/GetList.php 0.00% 38 Missing ⚠️
core/src/Revolution/Processors/Context/GetList.php 9.37% 29 Missing ⚠️
...evolution/Processors/Workspace/Lexicon/GetList.php 0.00% 12 Missing ⚠️
...rocessors/Element/TemplateVar/Template/GetList.php 0.00% 9 Missing ⚠️
...volution/Processors/Security/Forms/Set/GetList.php 0.00% 6 Missing ⚠️
...tion/Processors/Security/Forms/Profile/GetList.php 0.00% 5 Missing ⚠️
...olution/Processors/Security/Group/User/GetList.php 0.00% 5 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.x   #16369      +/-   ##
============================================
- Coverage     21.73%   21.58%   -0.16%     
- Complexity    10483    10564      +81     
============================================
  Files           561      561              
  Lines         31620    31926     +306     
============================================
+ Hits           6873     6890      +17     
- Misses        24747    25036     +289

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov