Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default gravatar type for user #16461

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

Ruslan-Aleev
Copy link
Collaborator

@Ruslan-Aleev Ruslan-Aleev commented Jul 28, 2023

What does it do?

In the 2.x branch, the gravatar image is enabled by default, BUT, because in code set mm gravatar type - the picture is always the same, which is not very useful for UI\UX.

Changed the type to retro, which generates a unique gravatar by email hash, and now you can better see which user is logged into the manager panel.

Before:
gravatar_1

After:
gravatar_2

gravatar_3

Why is it needed?

UI\UX

Related issue(s)/PR(s)

N\A

@Ruslan-Aleev Ruslan-Aleev added this to the v2.8.6 milestone Jul 28, 2023
@Ruslan-Aleev Ruslan-Aleev added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed Pull request requires review and testing. labels Jul 28, 2023
@SnowCreative
Copy link
Contributor

Hmm. Interesting feature. But maybe toggle this on using a system setting? I'd personally prefer the generic image, while others may enjoy the auto-created ones.

@Ruslan-Aleev
Copy link
Collaborator Author

@SnowCreative The 2.x branch is frozen, so there is no point in making additional system settings. Even in such a simple version, PR is unlikely to be merged in...

@opengeek
Copy link
Member

opengeek commented Jul 28, 2023

The 2.x branch is frozen, so there is no point in making additional system settings.

If it is frozen, then why should this change be accepted?

Even in such a simple version, PR is unlikely to be merged in...

And why do you say that?

@opengeek
Copy link
Member

The 2.x branch is frozen, so there is no point in making additional system settings.

If it is frozen, then why should this change be accepted?

Even in such a simple version, PR is unlikely to be merged in...

And why do you say that?

And for clarity, I thought this was a good change…

@Ruslan-Aleev
Copy link
Collaborator Author

If it is frozen, then why should this change be accepted?

Here the changes are not global, so I sent a PR, if the PR is merged - it's good, if not - it's not critical =)

And why do you say that?

More valuable PRs are waiting for testing, there are almost no testers, so I have little optimism, but I will be glad to be wrong.

@JoshuaLuckers JoshuaLuckers added the pr/port-to-3 Pull request has to be ported to 3.x. label Jul 31, 2023
@Ruslan-Aleev Ruslan-Aleev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Aug 1, 2023
@matdave
Copy link
Contributor

matdave commented Aug 11, 2023

I'd be +1 for making this a system setting

@opengeek opengeek merged commit 775274f into modxcms:2.x Sep 28, 2023
5 checks passed
@Ruslan-Aleev Ruslan-Aleev deleted the 2.x-gravatar-type branch September 28, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/port-to-3 Pull request has to be ported to 3.x. pr/ready-for-merging Pull request reviewed and tested and ready for merging. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants