-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default gravatar type for user #16461
Conversation
Hmm. Interesting feature. But maybe toggle this on using a system setting? I'd personally prefer the generic image, while others may enjoy the auto-created ones. |
@SnowCreative The 2.x branch is frozen, so there is no point in making additional system settings. Even in such a simple version, PR is unlikely to be merged in... |
If it is frozen, then why should this change be accepted?
And why do you say that? |
And for clarity, I thought this was a good change… |
Here the changes are not global, so I sent a PR, if the PR is merged - it's good, if not - it's not critical =)
More valuable PRs are waiting for testing, there are almost no testers, so I have little optimism, but I will be glad to be wrong. |
I'd be +1 for making this a system setting |
What does it do?
In the 2.x branch, the gravatar image is enabled by default, BUT, because in code set
mm
gravatar type - the picture is always the same, which is not very useful for UI\UX.Changed the type to
retro
, which generates a unique gravatar by email hash, and now you can better see which user is logged into the manager panel.Before:
After:
Why is it needed?
UI\UX
Related issue(s)/PR(s)
N\A