Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Update: Add No Bucket Check #16496

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

matdave
Copy link
Contributor

@matdave matdave commented Nov 15, 2023

What does it do?

Add a "No Bucket Check" option for users with limited access.

Why is it needed?

Some access keys aren't authorized to list buckets, so will fail to initialize the S3 source when it checks if the bucket exists.

How to test

This would take some set up. Primarily, this is addressing an issue we are facing with updating our internal S3 provider. However, it is a common feature and the logic was ported from rclone https://rclone.org/s3/#s3-no-check-bucket

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 21.57%. Comparing base (73bfd27) to head (376734c).
Report is 106 commits behind head on 3.x.

Files Patch % Lines
core/src/Revolution/Sources/modS3MediaSource.php 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16496      +/-   ##
============================================
- Coverage     21.68%   21.57%   -0.12%     
- Complexity    10496    10567      +71     
============================================
  Files           561      561              
  Lines         31703    31949     +246     
============================================
+ Hits           6875     6892      +17     
- Misses        24828    25057     +229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mark-H Mark-H modified the milestones: v3.0.5, v3.1.0 Feb 10, 2024
@matdave matdave requested a review from Mark-H March 18, 2024 19:15
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opengeek opengeek merged commit e1e45ff into modxcms:3.x May 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants