Update phpThumb to v1.7.22-202312071641

[opengeek]

What does it do?

Updates phpThumb to v1.7.22-202312071641

Why is it needed?

Fixes the issue with thumbnails not being generated when running on PHP 7.4 (or earlier).

How to test

Make sure thumbnails are being generated in the media browser when running on PHP 7.4.

Related issue(s)/PR(s)

Resolves #16468 for the 2.x branch

[halftrainedharry]

running on PHP 7.4 (or earlier).

If you want to support PHP versions < PHP 7.1, then there is still a problem with the void return type.

See this forum topic:
https://community.modx.com/t/phpthumb-issue-with-modx-2-8-6-and-php-5-6/7224

[opengeek]

running on PHP 7.4 (or earlier).

If you want to support PHP versions < PHP 7.1, then there is still a problem with the void return type.

See this forum topic: https://community.modx.com/t/phpthumb-issue-with-modx-2-8-6-and-php-5-6/7224

We have no intention of maintaining support for a PHP version that ended both active and security support over five years ago. And I would never expect the phpThumb project to do so, either.

[rthrash]

I can confirm when manually applying the changes to the files in this PR that it definitely fixes the problem of missing thumbnails.

[theboxer]

👍

[modxcommunity]

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/problem-with-uncacher-when-upgrading-to-2-8-7/8035/5

[leoandrews]

running on PHP 7.4 (or earlier).

If you want to support PHP versions < PHP 7.1, then there is still a problem with the void return type.
See this forum topic: https://community.modx.com/t/phpthumb-issue-with-modx-2-8-6-and-php-5-6/7224

We have no intention of maintaining support for a PHP version that ended both active and security support over five years ago. And I would never expect the phpThumb project to do so, either.

Not a unreasonable position to have, on paper. HOWEVER - your support docs for 2.8.x clearly state PHP5.6 is supported. So you probably DO need support it. Failing to do so, is breaking people's upgrades and eroding trust in the product.

[rthrash]

The support docs need to be updated, then, and will be. Encouraging/facilitating people to deploy sites on unsupported ancient versions of PHP is not in anyone's best interest.

If someone needs old PHP, they can stick with 2.8.x until the next major version of MODX is released at which point 3.x will be the older supported version going forward.