Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for modManagerLog.occurred column #16527

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix default value for modManagerLog.occurred column #16527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/model/modx/mysql/modmanagerlog.map.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
'fields' =>
array (
'user' => 0,
'occurred' => NULL,
'occurred' => 'CURRENT_TIMESTAMP',
'action' => '',
'classKey' => '',
'item' => '0',
Expand All @@ -35,8 +35,8 @@
array (
'dbtype' => 'datetime',
'phptype' => 'datetime',
'null' => true,
'default' => NULL,
'null' => false,
'default' => 'CURRENT_TIMESTAMP',
),
'action' =>
array (
Expand Down
2 changes: 1 addition & 1 deletion core/model/schema/modx.mysql.schema.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@

<object class="modManagerLog" table="manager_log" extends="xPDOSimpleObject">
<field key="user" dbtype="int" precision="10" attributes="unsigned" phptype="integer" null="false" default="0" />
<field key="occurred" dbtype="datetime" phptype="datetime" null="true" default="NULL" />
<field key="occurred" dbtype="datetime" phptype="datetime" null="false" default="CURRENT_TIMESTAMP" />
<field key="action" dbtype="varchar" precision="100" phptype="string" null="false" default="" />
<field key="classKey" dbtype="varchar" precision="100" phptype="string" null="false" default="" />
<field key="item" dbtype="varchar" precision="191" phptype="string" null="false" default="0" />
Expand Down
13 changes: 13 additions & 0 deletions setup/includes/upgrades/mysql/2.8.7-pl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php
/**
* MySQL upgrade script for 2.8.7
*
* @var modX $modx
* @package setup
*/

$class = 'modManagerLog';
$table = $modx->getTableName($class);

$description = $this->install->lexicon('alter_column', array('column' => 'occurred', 'table' => $table));
$this->processResults($class, $description, array($modx->manager, 'alterField'), array($class, 'occurred'));
Loading