Fix preview thumbnailing for images with ampersand (&) in file name #16609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opengeek
pushed a commit
that referenced
this pull request
Sep 3, 2024
…16609) ### What does it do? URL encodes the src property used in building the image TV type’s phpthumb preview link. ### Why is it needed? The unencoded property was mangling the request when an ampersand was present in the file source path, preventing the creation of preview images. ### How to test 1. Create at least one folder and one image with '&' in the name. 2. Create an image TV, assign it to a Template/Resource, and select the images you’ve created via the TV. 3. Verify that the preview shows and also shown when selecting a different image via the TV. ### Related issue(s)/PR(s) For 3.x: Resolves #14264 Resolves #13412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
URL encodes the src property used in building the image TV type’s phpthumb preview link.
Why is it needed?
The unencoded property was mangling the request when an ampersand was present in the file source path, preventing the creation of preview images.
How to test
Related issue(s)/PR(s)
For 3.x:
Resolves #14264
Resolves #13412