Dynamic manager path in setup #16755
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added MODX_MANAGER_URL to the setup options, so that "Files are already in-place" is checkable on sites where manager/ has been renamed.
opengeek
reviewed
Nov 4, 2025
Member
opengeek
left a comment
opengeek
left a comment
There was a problem hiding this comment.
You can already achieve the ability to customize the manager path/url using the advanced distribution, along with several other paths/urls. I don't see the need for this in the standard distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MODX_MANAGER_URL to the setup options, so that "Files are already in-place" is checkable on sites where manager/ has been renamed.
What does it do?
The function on the first page of the setup checks if the
manager/-folder exists, and let's the user check "Files are already in-place". I've replaced the stringmanager/withMODX_MANAGER_URLso it reads the dynamic value fromconfig.inc.php.Why is it needed?
Many of us rename the
manager/-page to either customize the experience or for security purposes. This fix enables us to install / upgrade a site and select "Files are already in-place".How to test
Rename manager and manager URL in
config.inc.php, then run setup.