-
-
Notifications
You must be signed in to change notification settings - Fork 531
Revert #14832 and Improve Tree Resource Contrast to Fix #16465 #16759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s#16465 This PR reverts modxcms#14832 and implements improved color contrast and icon styling to resolve the usability issue described in modxcms#16465. - Restores the previous SCSS files removed in modxcms#14832 - Adjusts color variables for better contrast and clarity - Aligns MODX 3 tree display with MODX 2 behavior for hidden/unpublished resources Fixes modxcms#16465. Requires asset build to see changes.
It needs to be changed in the 2.x branch =) My logic is as follows:
|
|
Hey @Ruslan-Aleev, Thanks for your feedback. Both approaches have merit, but I'm prioritizing consistency across the platform. The 2.x convention (italics for unpublished, light text for hidden from menu, standard for shown in menu) is established and functional. Power users working with both 2.x and 3.x daily rely on this visual consistency. I've confirmed this with several developers who find the current inconsistency disruptive to their workflow. Since 2.x is mostly in maintenance mode with limited changes, and many 2.x users won't upgrade to latest releases, it's logical to align 3.x with established 2.x conventions rather than modify 2.x. Users on 3.x are more likely to keep installations current. The current solution addresses a real usability problem for active developers. For teams preferring the #14832 approach, I'll provide a plugin solution. What are your thoughts on this direction? |
|
@jaygilmore Hi! |
|
@Ruslan-Aleev, @smg6511 I'm going to actually delete this PR and keep the current 3.x color scheme and increase the contrast slightly and then use the outlines for unpublished and deleted Resources. Again, it will only use font-weight to handle the icon outline display. |
|
Closing in favour of #16760 16761 |
Requires asset build to see changes.
What does it do?
This PR reverts #14832 and implements improved color contrast and icon styling to resolve the usability issue described in #16465.
Why is it needed?
How to test
Checkout this PR, build assets and view the Resource Tree to see the changes.
Related issue(s)/PR(s)
Resolves #16465.
Other Notes
For folks wishing to have the conventions within #14832, I'll follow in that with code for a plugin to handle that.
Difference Image
Commments and feedback welcome.