Skip to content

Conversation

@jaygilmore
Copy link
Member

@jaygilmore jaygilmore commented Jul 16, 2025

Requires asset build to see changes.

What does it do?

This PR reverts #14832 and implements improved color contrast and icon styling to resolve the usability issue described in #16465.

Why is it needed?

How to test

Checkout this PR, build assets and view the Resource Tree to see the changes.

Related issue(s)/PR(s)

Resolves #16465.

Other Notes

For folks wishing to have the conventions within #14832, I'll follow in that with code for a plugin to handle that.

Difference Image

after-and-before-pr

Commments and feedback welcome.

…s#16465

This PR reverts modxcms#14832 and implements improved color contrast and icon styling to resolve the usability issue described in modxcms#16465.

- Restores the previous SCSS files removed in modxcms#14832
- Adjusts color variables for better contrast and clarity
- Aligns MODX 3 tree display with MODX 2 behavior for hidden/unpublished resources

Fixes modxcms#16465.

Requires asset build to see changes.
@Ruslan-Aleev
Copy link
Collaborator

Aligns MODX 3 tree display with MODX 2 behavior for hidden/unpublished resources so that both versions have a consistent UX convention.

It needs to be changed in the 2.x branch =)
I made a #14832 and the complaint was that "Published & Visible" looks similar to "Unpublished & Visible", i.e. Published and Unpublished look almost the same, which is strange, because resource publication is a parameter that should be visible in the tree immediately. In my opinion, italic is not enough for visual separation.

My logic is as follows:

  • Bright resource - published;
  • Pale resource - unpublished;
  • Italic - hidden in the menu (+ publication status);
    In the 2.x branch it is mixed up, and bright can be both published and not, which, in my opinion, is illogical and breaks the UX.

@jaygilmore
Copy link
Member Author

Hey @Ruslan-Aleev,

Thanks for your feedback.

Both approaches have merit, but I'm prioritizing consistency across the platform. The 2.x convention (italics for unpublished, light text for hidden from menu, standard for shown in menu) is established and functional.

Power users working with both 2.x and 3.x daily rely on this visual consistency. I've confirmed this with several developers who find the current inconsistency disruptive to their workflow.

Since 2.x is mostly in maintenance mode with limited changes, and many 2.x users won't upgrade to latest releases, it's logical to align 3.x with established 2.x conventions rather than modify 2.x. Users on 3.x are more likely to keep installations current.

The current solution addresses a real usability problem for active developers. For teams preferring the #14832 approach, I'll provide a plugin solution.

What are your thoughts on this direction?

@Ruslan-Aleev
Copy link
Collaborator

Ruslan-Aleev commented Jul 18, 2025

@jaygilmore Hi!
I think the problem is not worth discussing, only a few people pay attention to it =)
I made the previous PR because both I and users had a problem with visual understanding of the publication status in the tree (and even now, I can hardly remember the logic of this design on 2.x, if the tree is not in front of my eyes =) ).
BUT if the behavior in 3.x creates more problems than benefits, then it is worth returning to the 2.x version, I think the plugin is not needed.
Thank you for your participation and suggested solutions!

@jaygilmore
Copy link
Member Author

@Ruslan-Aleev, @smg6511 I'm going to actually delete this PR and keep the current 3.x color scheme and increase the contrast slightly and then use the outlines for unpublished and deleted Resources. Again, it will only use font-weight to handle the icon outline display.

@jaygilmore
Copy link
Member Author

Closing in favour of #16760 16761

@jaygilmore jaygilmore closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Usability Issue with Determining Unpublished vs Hidden

3 participants