fix(element): Add label to Property Set dropdown on Properties tab#16896
Open
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Open
fix(element): Add label to Property Set dropdown on Properties tab#16896Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Conversation
- Add 'Property Sets:' label in modx.grid.element.properties.js toolbar - Add 'Property Sets:' label in modx.panel.property.set.js tbar - Uses existing lexicon key propertysets Resolves modxcms#13901
Code ReviewSummaryAdds a "Property Sets:" label from the existing VerdictApprove — minimal, correct change using existing lexicon. |
mkschell
approved these changes
Mar 5, 2026
Member
mkschell
left a comment
mkschell
left a comment
There was a problem hiding this comment.
Agreed, clean, minimal UX improvement. Lexicon key already in use so i18n is covered. Good to merge imo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a visible label "Property Sets:" for the Property Set dropdown on the Properties tab of elements (Chunk, Snippet, Template, etc.). The label is rendered in the toolbar in
modx.grid.element.properties.jsand in the tbar inmodx.panel.property.set.js, using the existing lexicon keypropertysets.Why is it needed?
The Property Set dropdown had no label, so users could not tell what the control was for. This change makes the UI clearer and fixes the missing label reported in the related issue.
How to test
Related issue(s)/PR(s)
Resolves #13901