feat(manager-log): Add manager links to log entries#16897
Open
Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Open
feat(manager-log): Add manager links to log entries#16897Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Ibochkarev wants to merge 3 commits intomodxcms:3.xfrom
Conversation
37f4997 to
427dc57
Compare
851a6c3 to
427dc57
Compare
Code ReviewSummaryAdds clickable manager links to Manager Log entries. Backend builds URLs via Suggestions
AssessmentWell-implemented feature covering all major object types. The switch-based mapping is justified since each type has distinct URL patterns and parameter keys. VerdictApprove — suggestions are optional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds clickable manager URLs to Manager Log entries. When a log entry references a resource, template, chunk, or other element, the grid now shows a link that opens the corresponding edit page in the manager.
Backend (
System/Log/GetList): NewgetManagerUrl(classKey, item, obj)builds the relative manager URL for resources, contexts, elements (template/chunk/snippet/plugin/category), user, menu, settings, access policy/template, resource group, media source, namespace, dashboard/widget, transport package, content type.Frontend (
modx.grid.manager.log): Object column uses a custom renderer that renders a link whenmanagerUrlis present, opening in a new tab.Why is it needed?
Improves workflow when reviewing manager logs—users can jump directly to the affected resource or element instead of searching manually.
How to test
Related issue(s)/PR(s)
Resolves #13780