fix(manager): increase Package Manager drag-and-drop image visibility#16899
Open
Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Open
fix(manager): increase Package Manager drag-and-drop image visibility#16899Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Conversation
Set opacity to 0.25 for #modx-panel-packages.drag-n-drop::before so the dragndrop.svg hint is visible as an intentional UI cue instead of appearing as a bug or artifact. Resolves modxcms#15989
Code ReviewSummaryAdds AssessmentMinimal CSS change, correct and harmless. Improves visibility of the drag-and-drop hint without being intrusive. VerdictApprove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Increases the opacity of the drag-and-drop hint image in the Package Manager from the default (effectively ~0.1) to
0.25for the#modx-panel-packages.drag-n-drop::beforepseudo-element in_build/templates/default/sass/index.scss. The compiled CSS is produced bygrunt sassduring build; this PR only changes the SCSS source.Why is it needed?
With the previous opacity, the dragndrop.svg hint was barely visible and could be mistaken for a visual bug or artifact. Making the hint clearly visible (while still subtle) improves UX and matches the intent of the drag-and-drop zone.
How to test
Related issue(s)/PR(s)
Resolves #15989