refactor(manager): remove main_nav_parent and user_nav_parent system settings#16908
Open
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Open
refactor(manager): remove main_nav_parent and user_nav_parent system settings#16908Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Ibochkarev wants to merge 1 commit intomodxcms:3.xfrom
Conversation
…settings Use fixed menu container names (topnav, usernav) in header controller. Remove settings from transport and all setting lexicons; add 3.3.0-pl upgrade script to delete existing DB records. Reduces confusion and matches menu configuration in Menu section. Resolves modxcms#15972
Ibochkarev
force-pushed
the
fix/15972-remove-nav-parent-settings
branch
from
c42a9dd to
5c2b7ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Removes the
main_nav_parentanduser_nav_parentsystem settings. The manager header controller now uses fixed menu container names (topnavfor main menu,usernavfor user menu) instead of reading these options. The two settings are removed from the core transport and from all setting lexicons; an upgrade script (3.3.0-pl) deletes any existing records from the database on upgrade.Why is it needed?
These settings confuse users and do not behave intuitively (e.g. setting
user_nav_parenttotopnavcan break menu display). Menu structure is already managed in the Menu section with fixed Main/User menu areas, so the extra system settings are redundant and add support burden.How to test
main_nav_parentoruser_nav_parentinsystem_settings, run setup in upgrade mode to a version that runs 3.3.0-pl. Confirm the upgrade log shows removal of those settings and manager menus still work.Related issue(s)/PR(s)
Resolves #15972