feat(packages): Add Install All and Update All buttons to package grid#16909
Draft
Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Draft
feat(packages): Add Install All and Update All buttons to package grid#16909Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Ibochkarev wants to merge 2 commits intomodxcms:3.xfrom
Conversation
- Add filter=uninstalled to GetList for bulk install - Add listPackages filter param in Transport layer - Add Install All / Update All buttons with sequential queue processing - Add lexicon keys for confirmations, progress, and completion messages - Use loadConsole for batch progress, refresh grid and trees on complete Resolves modxcms#5897
d7c6879 to
1a14035
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.x #16909 +/- ##
============================================
+ Coverage 21.64% 21.67% +0.03%
- Complexity 10764 10785 +21
============================================
Files 566 566
Lines 33005 33153 +148
============================================
+ Hits 7144 7186 +42
- Misses 25861 25967 +106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Added new test cases for listPackages method with and without filters. - Included a new directory for Workspace tests in phpunit.xml.
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/the-future-of-modx-ideas-roadmap-and-release-cycle/8995/32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds "Install All" and "Update All" buttons to the package grid (Workspace → Packages) for bulk installation and updating of packages.
Backend:
filterparameter to GetList processor;filter=uninstalledreturns only not-installed packageslistPackages()in modTransportPackage (base and mysql) with$filterargumentfilter === 'uninstalled', applies condition(installed IS NULL OR installed = '0000-00-00 00:00:00')Frontend:
filter=uninstalled, then runs sequential Install for eachupdateable === true, then for each runs CheckForUpdates → Rest/Download → InstallparseGetListResponse(),getConnectorErrorMessage()Lexicon:
core/lexicon/en/workspace.inc.php:package_install_all,package_update_all, confirmations, progress, completion messagesWhy is it needed?
Speeds up fresh MODX installations and bulk package updates by allowing users to install or update all packages in one action instead of clicking each package individually.
How to test
Related issue(s)/PR(s)
Resolves #5897