Skip to content

Commit

Permalink
fix(menu): disabled hideAfterClick sub-menu-label
Browse files Browse the repository at this point in the history
  • Loading branch information
moecasts committed Jul 2, 2024
1 parent fdf9e97 commit 3c45d28
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/casts-menu/src/components/hooks/use-menu-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export const useMenuItem = (props: UseMenuItemProps) => {
onClick?.({ e: event });

if (
subMenuContext.hideAfterClick &&
(props.hideAfterClick ?? subMenuContext.hideAfterClick) &&
subMenuContext.expandType === 'popup'
) {
subMenuContext.onOpenChange?.(false);
Expand Down
1 change: 1 addition & 0 deletions packages/casts-menu/src/components/sub-menu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export const SubMenu = forwardRef(
focusable={focusable}
className={innerClasses}
style={innerStyles}
hideAfterClick={false}
{...innerEvents}
>
{label}
Expand Down
2 changes: 2 additions & 0 deletions packages/casts-menu/src/components/types/menu-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export type UseMenuItemProps = BaseComponentProps &
focusable?: boolean;

label?: ReactNode;

hideAfterClick?: boolean;
};

export type MenuItemProps = UseMenuItemProps & {
Expand Down

0 comments on commit 3c45d28

Please sign in to comment.