Skip to content

(doc) add and refine fields to model_collection.yml #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leohearts wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(doc) add and refine fields to model_collection.yml #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c0dec9
Update model_collection.yml
leohearts Jul 1, 2025
99475df
Update model_collection.yml
leohearts Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 58 additions & 5 deletions .github/ISSUE_TEMPLATE/model_collection.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,19 @@ body:
- type: input
attributes:
label: "Provider"
description: "The provider of the model."
description: "The organization that created the model. (e.g., openai, meta)"
placeholder: "openai"
validations:
required: true

- type: input
attributes:
label: "Model Family"
description: "The base name for the model series (e.g., Llama 3, Gemma, GPT-4)."
placeholder: "Gemma"
validations:
required: true
Comment on lines +14 to +20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR introduces the Model Family field, and several others later in the file (e.g., Model URL, Release Date, Context Window). However, these new fields are not defined in the backend Model struct in cmd/tools/jem-generator/types/types.go.

As a result, any data provided for these new fields in an issue will not be processed by the jem-generator and will be lost. This makes the additions non-functional.

To fix this, the Model struct in cmd/tools/jem-generator/types/types.go and the generator logic that uses it must be updated to handle these new fields. Was this intended to be part of a different PR? Without the backend changes, this PR is incomplete.


- type: input
attributes:
label: "Model ID"
Expand All @@ -19,14 +27,58 @@ body:
validations:
required: true

- type: input
attributes:
label: "Model URL"
description: "URL of the model's repository, if not applicable, link to the official model card or product page."
placeholder: "https://huggingface.co/google/gemma-3n-E4B-it"

- type: input
attributes:
label: "Release Date"
description: "The date the model was publicly released."
placeholder: "YYYY-MM-DD"

- type: input
attributes:
label: "Context Window (Tokens)"
description: "Maximum number of tokens in a single request."
placeholder: "8192"

- type: dropdown
attributes:
label: "Architecture"
options:
- label: Transformer
- label: Mixture of Experts (MoE)
- label: Other

- type: input
attributes:
label: "Parameters (Billions)"
description: "The number of parameters in the model, in billions (e.g., 8, 70, 175)."
placeholder: "70"

- type: input
attributes:
label: "Training Data Cutoff"
description: "The knowledge cutoff date for the model's training data."
placeholder: "YYYY-MM"

- type: input
attributes:
label: "License"
description: "The software license for the model."
placeholder: "Apache 2.0"

- type: checkboxes
attributes:
label: "Model Capabilities"
description: "The capabilities of the model."
options:
- label: "streaming"
- label: "reasoning"
- label: "tool-call"
- label: "tool-calling"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The capability tool-calling is inconsistent with the value expected by the backend. The generator code in cmd/tools/jem-generator/types/types.go defines this capability as tool-call. Using a different value here will lead to data processing issues. Please use the value defined in the system to ensure consistency.

        - label: "tool-call"


- type: checkboxes
attributes:
Expand All @@ -46,14 +98,15 @@ body:
options:
- label: "text"
- label: "image"
- label: "json"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The output modality json is not a recognized value in the backend. The Modality type in cmd/tools/jem-generator/types/types.go only defines text, audio, image, video, and vector. Submitting json will cause data inconsistencies. Please either remove this option or update the backend to support it.

- label: "audio"
- label: "video"
- label: "vector"

- type: checkboxes
attributes:
label: "Model Endpoints"
description: "The endpoints of the model."
description: "Supported API endpoints of the model."
options:
- label: "chat-completion"
- label: "completion"
Expand All @@ -65,5 +118,5 @@ body:
- type: textarea
attributes:
label: "Additional Information"
description: "Additional information about the model."
placeholder: "Additional information about the model."
description: "Any other relevant details, such as benchmark performance (MMLU, GSM8K), architectural notes, etc."
placeholder: "MMLU score: 86.4%"