-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a floating layer #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Let me try this out.
Do you have to send the floating window to front or send the tiled windows to back while dragging floating windows / switching tiled windows in order to keep the floating windows on top and visible?
I am treating this like less of a discrete layer than a per-window-id ignore list, since that's primarily my use case. I tried bringing all of the floating windows to the front when focusing one of them, and it felt wrong to me. One potential awkwardness with this approach is that adding a window to the floating list and then focusing a tiled window does not bring all the other tiled windows to the front; so you can end up with a mix of tiled windows above/behind floating windows. In practice so far this feels more macOS-like, but perhaps less PaperWM-like. |
Looks good to me! I haven't found any issues when using this for a bit. I don't think there's a good way to keep floating windows on top of tiled windows. Before I merge, could you please squash your commits into just one and also update the example keybindings in the README: https://github.com/mogenson/PaperWM.spoon?tab=readme-ov-file#usage |
Windows in the floating layer are tracked by their window id in `is_floating`, and persisted across restarts/reloads via hs.settings. The new toggle_floating action can be used to flip the focused window between floating and tiled state. Fixes mogenson#24.
f47357b
to
4686346
Compare
Done, thanks! |
Windows in the floating layer are tracked by their window id in
is_floating
, and persisted across restarts/reloads viahs.settings
. The newtoggle_floating
action can be used to flip the focused window between floating and tiled state.Would love any feedback here!
Fixes #24.