Add back closure support #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implicitly adds the "closure" pragma back to the proc. This way, getDbProc is allowed to be a closure, which it typically has to be.
getDb so far has been {.nimcall.} while normal users are likely to define getDb procs as {.closure.}.
You can try to fix this error by allowing both with a generic, but that somehow causes
nim to run into ambiguous call errors as suddenly both the newPool
proc for postgres.DbConn and for sqlite.DbConn match one another.
To fix this we just enforce everything being a closure.
|
@PhilippMDoerner thanks for the fix! |
|
I noticed it for the most part because I updated my backend projectand suddenly my compilation broke completely 😄 |
|
@PhilippMDoerner sorry for the trouble. I've noticed that the tests stopped passing with Nim 2.2.0 and fixed them 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back closure support that was originally removed by this commit: 7f766e4
The "proc" annotation to the parameter type is required for this to support closures. If it isn't there, you only support essentially proc() = discard