-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): remove memory leak in api #898
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #898 +/- ##
==========================================
- Coverage 69.63% 69.51% -0.12%
==========================================
Files 191 191
Lines 10564 10622 +58
==========================================
+ Hits 7356 7384 +28
- Misses 2782 2808 +26
- Partials 426 430 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -102,6 +103,21 @@ func NewHandler(db moira.Database, log moira.Logger, index moira.Searcher, confi | |||
router.Get("/swagger/*", httpSwagger.Handler( | |||
httpSwagger.URL("/api/swagger/doc.json"), | |||
)) | |||
router.Route("/debug/pprof", func(router chi.Router) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ого
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
понял, спасибо
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
никогда не замечал
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я уже успел написал скрипт, который нагрузку генерирует и похоже зря :(
/build |
Build and push Docker images with tag: fix-remove-memory-leak-in-api.2023-08-30.ce955b6 |
Remove memory leak in api
These changes should definitely fix the memory leak associated with trigger index benchmarks, but are non-guaranteed to fix the entire issue