Skip to content

Conversation

@elijah0kello
Copy link
Member

chore(mojaloop/#3456): nodejs upgrade - mojaloop/project#3456

  • Updated package.json scripts to use new audit tools
  • Upgraded NodeJS from v16 to v18 LTS
  • Updated CI config to use NodeJS latest LTS version
  • Updated CI config to display runtime versions for each job
  • Upgraded NPM dependencies
  • Fixed CI bugs caused by the NodeJS upgrade
  • Updated CI pipeline use NVM to select node version from .nvmrc file
  • Migrated master branch to main

@elijah0kello
Copy link
Member Author

I'd like the PR to be reviewed. I have tried to implement to the best of my knowledge. This repo had some differences from email notifier so it needs some scrutiny

@oderayi and @PaulGregoryBaker kindly review and advise

Copy link

@oderayi oderayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elijah0kello A few observations:

  • I pulled your branch and ran the unit tests locally and they're failing. The units tests need to pass
  • The CI config in this repo is quite old. Please overhaul with what we now have in email-notifier. You can copy the config.yaml in email notifier to overwrite the config.yaml here and modify as needed (if need be).
  • As much as possible synchronize the package.js in this repo with the package.json in email-notifier repo (especially the npm scripts) to help bring this repo up to current standards
  • Ensure the CI jobs run. Please reach out if you're unable to get this working.

@elijah0kello
Copy link
Member Author

Thanks for the comments. Let me implement ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants