Fix setting end-of-event false after it's true #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfgeorge
changed the title
sfgeorge
force-pushed
the
unset_end_of_event
branch
from
2a17117
to
3732fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given this setter:
It's expected the following getter would return 0:
Actual result:
Cause
The previous un-setter is trying to negate END_OF_EVENT, but does so by subtracting
15 - 128:This does not produce the intended effect, and end-of-event remains set. (Additionally, side effects on other properties in
@flagsare also possible).Not really a big deal
Rest assured however, this "bug" doesn't actually exhibit bad behavior in sippy_cup. Because its code never sets dtmf_frame.end_of_event more than 1 time per instance. There is no place in the code where multiple values are set for end_of_event of the same dtmf_frame instance. So this is a theoretical bug, at best.