Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: use regexparam package #395

Merged
merged 2 commits into from
Dec 9, 2023
Merged

v3: use regexparam package #395

merged 2 commits into from
Dec 9, 2023

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Dec 9, 2023

  • this is breaking change but i think that it is better to use original package

@jeetiss jeetiss requested a review from molefrog December 9, 2023 08:37
@jeetiss jeetiss self-assigned this Dec 9, 2023
Copy link

codesandbox bot commented Dec 9, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Dec 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Dec 9, 2023

size-limit report 📦

Path Size
packages/wouter/esm/index.js 2.07 KB (-0.15% 🔽)
packages/wouter/esm/use-browser-location.js 658 B (0%)
packages/wouter/esm/memory-location.js 834 B (0%)
packages/wouter/esm/use-hash-location.js 737 B (0%)
packages/wouter-preact/esm/index.js 1.95 KB (-0.6% 🔽)
packages/wouter-preact/esm/use-browser-location.js 552 B (0%)
packages/wouter-preact/esm/use-hash-location.js 607 B (0%)
packages/wouter-preact/esm/memory-location.js 702 B (0%)

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd372ac) 100.00% compared to head (db09ab5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@molefrog molefrog merged commit 3c465ef into v3 Dec 9, 2023
5 checks passed
@molefrog molefrog deleted the use-regexparam-package branch December 9, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants