Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional css to theme #3413

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Conversation

MaxPostema
Copy link
Contributor

@MaxPostema MaxPostema commented Feb 21, 2024

Fixes: #3315

how to test:

Add the directory styling via additional css theme and see it working on every directory page

/* removing the built-in nav because it conflicts */
nav[aria-label="breadcrumb"]:not(.directory-nav) {
  display: none;
}
ol.breadcrumb {
  margin-top: 0.25rem !important;
  margin-bottom: 0.25rem !important;
}

/* emx2 style override */
#app > div {
  background-color: white !important;
}
nav.navbar {
  background-color: #e9ecef !important;
}
nav.navbar a.nav-link,
nav.navbar button.btn {
  color: #495057 !important;
  background-color: transparent;
}
nav.navbar a.nav-link:hover,
nav.navbar button.btn:hover {
  color: #ec6707 !important;
}
nav.navbar button.btn.btn-outline-light:not(.border-0) {
  border-color: #495057 !important;
}
nav.navbar button.btn.btn-outline-light:not(.border-0):hover {
  border-color: #ec6707 !important;
  background-color: #ec6707 !important;
  color: #dbedff !important;
}

.filterbar > details.dropdown-button > summary {
  color: #08205c !important;
}
.filterbar > details.dropdown-button[open] > summary,
.filterbar > details.dropdown-button:hover > summary,
.filterbar > details.text-white > summary {
  color: white !important;
}

todo:

  • updated docs in case of new feature

@MaxPostema MaxPostema marked this pull request as ready for review February 21, 2024 15:33
@@ -45,6 +45,9 @@
:locales="locales"
/>
</div>
<component is="style">
{{ session.settings.additionalCss }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really, that simple? nice. I do understand you want it here because this one always loads

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MaxPostema MaxPostema merged commit 069ff17 into master Feb 27, 2024
5 checks passed
@MaxPostema MaxPostema deleted the feat/additional-css-in-theme branch February 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory App: Menu color should be consistent
2 participants