feat: add dataset details #3431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add modal render for dataset details in cohort page Update datasetDisplay to include resource ( full primary key) Extend datasetDisplay view more details, include basic mapped render Closes #3424
mswertz
requested changes
Feb 23, 2024
no , can you add a example where the keywords are missing ? |
|
mswertz
approved these changes
Feb 26, 2024
|
I think the list rendering was a explicit request from from the UMCG team , i agree it down not scale nice for large lists , we could use the tree render |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modal render for dataset details in cohort page Update datasetDisplay to include resource ( full primary key) Extend datasetDisplay view more details, include basic mapped render
Closes #3424
how to test:
todo: