Skip to content

fix(nuxt3-ssr): open force link in new tab #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2024
Merged

fix(nuxt3-ssr): open force link in new tab #4151

merged 4 commits into from
Aug 21, 2024

Conversation

MaxPostema
Copy link
Contributor

What are the main changes you did:

  • open force link in new tab

how to test:

  • opening the link works and opens in a new tab

@MaxPostema MaxPostema marked this pull request as draft August 20, 2024 12:26
@MaxPostema MaxPostema marked this pull request as ready for review August 20, 2024 12:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

erikzwart
erikzwart approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@erikzwart erikzwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on preview:
image
Aggregates button links out to dashboard:
image

@MaxPostema MaxPostema merged commit a53aeef into master Aug 21, 2024
6 checks passed
@MaxPostema MaxPostema deleted the fix/open_force_link_in_tab branch August 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzwart erikzwart erikzwart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxPostema @erikzwart