-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add docs links #4197
feat: Add docs links #4197
Conversation
Closes #587
Quality Gate passedIssues Measures |
maybe open in new tab would be better , and maybe hide in cohortOnly context |
I agree that opening 'upload data' and 'manual' in a new tab each time would be more user-friendly. Not sure what you mean by cohortOnly, though? |
@marijevdgeest have you seen this yet? Does this match your spec? |
@connoratrug where can I test this again? (prev 4197 gives 404) |
Nice. Please could you change the text to 'Manuals' (meervoud)? @connoratrug We need to discuss later where we want the 'about' information. I'll make a separate story for that (the manuals are currently more important). But if the text is changed to 'Manuals' I'm happy. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Please could you change the text to 'Manuals' (meervoud)? @connoratrug
We need to discuss later where we want the 'about' information. I'll make a separate story for that (the manuals are currently more important). But if the text is changed to 'Manuals' I'm happy. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good in the code!
Quality Gate passedIssues Measures |
What are the main changes you did:
how to test:
todo: