-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(catalogue): add missing resource types and otherwise use raw type name #4348
Conversation
https://preview-emx2-pr-4348.dev.molgenis.org/catalogue-demo/ssr-catalogue/all shows 'clinical trail' instead of expected 'clinical trails' , the paths ( routes of the other types are , all lowercase no whitespace ( for example ssr-catalogue/all/datasources ) but clinical trail has a path of 'sr-catalogue/all/Clinical%20trial' |
Indeed. If all is well this is now fixed. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on the preview server. Perhaps out of the scope of this PR, but the label below the resource logo and count is still default 'Cohorts & Biobanks'. Perhaps change this to use the raw type name instead so it at least matches the name?
indeed. done. |
Closes #4342
Using data from https://data-catalogue-acc.molgeniscloud.org/catalogue/ssr-catalogue
Before:
After: