Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(catalogue): update catalogue model req res type #4373

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat(catalogue): update catalogue model req res type #4373

merged 4 commits into from
Oct 17, 2024

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did:

  • Set resource.type field to required
  • Set empty demo data Resource.type fields to 'Other type'
  • Bump version table

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@connoratrug connoratrug merged commit 4d341d9 into master Oct 17, 2024
6 checks passed
@connoratrug connoratrug deleted the feat/update-catalogue-model-req-res-type branch October 17, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrendaHijmans BrendaHijmans BrendaHijmans approved these changes

@mswertz mswertz Awaiting requested review from mswertz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @BrendaHijmans