Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalogue): 4367 format date as year #4376

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented Oct 17, 2024

Closes #4367

What are the main changes you did:

  • format the date as year

note: might be more of a model issue , would be nice to get the format from the metadata
used to be everything was a date, catalogue model now has mix; date, year as number , year as string , maybe others
todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link

@connoratrug connoratrug changed the title fix: fix 4367 format date as year fix(catalogue): 4367 format date as year Oct 17, 2024
@mswertz
Copy link
Member

mswertz commented Oct 17, 2024

t be more of a model issue , would be nice to get the format from the metadata
usedto be everything was a date, catalogue model now has mix of data, year as number , year as string , maybe others
todo:

indeed. We already have period data type, a year data type would make sense.

@mswertz
Copy link
Member

mswertz commented Oct 17, 2024

t be more of a model issue , would be nice to get the format from the metadata
usedto be everything was a date, catalogue model now has mix of data, year as number , year as string , maybe others
todo:

indeed. We already have period data type, a year data type would make sense.

And more generally, why don't we show the date if it is a date?

@mswertz mswertz requested a review from BrendaHijmans October 17, 2024 17:59
@mswertz
Copy link
Member

mswertz commented Oct 17, 2024

@BrendaHijmans if we use date then we should show the date? or should we revert to year?

Copy link
Contributor

@BrendaHijmans BrendaHijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue linked to this PR was closed after this comment:
"Why are we changing a date that is filled out into year? We made a deliberate choice to include start and end date into the collection events and end year/start year for resources. Data collection period may be more precisely recorded than the start/end of a resource."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants