Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(central): schema names with - should be allowed #4391

Merged
merged 15 commits into from
Oct 29, 2024

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Oct 24, 2024

needed because of 'catalogue-demo' schema (cannot now be created via UI while we use it for tests)

closes #4400

Copy link
Contributor

@chinook25 chinook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesnt work: test-test fails. Regex needs to be: /^(?!.* _|.*_ )[-a-zA-Z][-a-zA-Z0-9 _]{0,30}$
(another - in between the last [])

@mswertz
Copy link
Member Author

mswertz commented Oct 24, 2024

Doesnt work: test-test fails. Regex needs to be: /^(?!.* _|.*_ )[-a-zA-Z][-a-zA-Z0-9 _]{0,30}$ (another - in between the last [])

indeed, thx

@mswertz
Copy link
Member Author

mswertz commented Oct 28, 2024

Doesnt work: test-test fails. Regex needs to be: /^(?!.* _|.*_ )[-a-zA-Z][-a-zA-Z0-9 _]{0,30}$ (another - in between the last [])

Shouldn't it be /^(?!.* _|.*_ )[a-zA-Z][-a-zA-Z0-9 _]{0,30}$ to prevent a start with -?

@chinook25
Copy link
Contributor

Doesnt work: test-test fails. Regex needs to be: /^(?!.* _|.*_ )[-a-zA-Z][-a-zA-Z0-9 _]{0,30}$ (another - in between the last [])

Shouldn't it be /^(?!.* _|.*_ )[a-zA-Z][-a-zA-Z0-9 _]{0,30}$ to prevent a start with -?

If you want to prevent that, yes ;)

Copy link

@mswertz mswertz merged commit 282d6d1 into master Oct 29, 2024
5 of 6 checks passed
@mswertz mswertz deleted the fix/schema_name_with_dash branch October 29, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I would like to make database names with a hyphen (-) in it.
3 participants