Skip to content

fix: 4273 extend regex to allow for parentheses #4395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did:

  • extend regex to allow for parentheses

Closes #4273

how to test:
-see issue , see unit test

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Contributor

@chinook25 chinook25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also have to change this in the backend?

@connoratrug
Copy link
Contributor Author

Might also have to change this in the backend?

a good point , do you know where ? i'll check

@connoratrug
Copy link
Contributor Author

connoratrug commented Oct 24, 2024

Might also have to change this in the backend?

a good point , do you know where ? i'll check

hmm look like its already in the backend , ill check with the preview once its up

@connoratrug
Copy link
Contributor Author

Might also have to change this in the backend?

a good point , do you know where ? i'll check

hmm look like its already in the backend , ill check with the preview once its up

i checked the backend (already) allows it

Copy link

@connoratrug connoratrug merged commit 714ab92 into master Oct 25, 2024
5 of 6 checks passed
@connoratrug connoratrug deleted the fix/4273-allow-parentheses-in-hyperlink branch October 25, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(hyperlinks): hyperlinks can contain parentheses
4 participants