Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 4398 save row with required file field #4402

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: 4398 save row with required file field #4402

merged 1 commit into from
Oct 30, 2024

Conversation

connoratrug
Copy link
Contributor

Closes #4398

What are the main changes you did:

  • Added FILE to the getTypedValue switch , have it resolve as string as file name is string

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug linked an issue Oct 25, 2024 that may be closed by this pull request
fix(forms): Cannot save record with file=required field #4398
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dtroelofsprins
dtroelofsprins approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A record with a required file column can be saved now without any issues.

@harmbrugge harmbrugge merged commit 23306db into master Oct 30, 2024
6 checks passed
@harmbrugge harmbrugge deleted the 4398-fixforms-cannot-save-record-with-file=required-field branch October 30, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtroelofsprins dtroelofsprins dtroelofsprins approved these changes

@harmbrugge harmbrugge harmbrugge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(forms): Cannot save record with file=required field
3 participants
@connoratrug @harmbrugge @dtroelofsprins