Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RDF): Output not always as expected when using table inheritance #4417

Merged
merged 21 commits into from
Nov 18, 2024

Conversation

svandenhoek
Copy link
Contributor

@svandenhoek svandenhoek commented Oct 31, 2024

What are the main changes you did:

  • Test that validated table inheritance in different ways re-used the same handler. This caused a bugged test to succeed while it should have failed as an API call with a rowId never describes the table/columns:
    if (rowId == null) {
    describeTable(builder, tableToDescribe);
    describeColumns(builder, tableToDescribe, columnName);
    }
  • When filtering on table, fields belonging to child tables were not included in the RDF output. If filtering by row includes the child table data, filtering on the table as a whole should include these as well so behaviour seems more coherent.

how to test:

  • All test should succeed.

known issues:

  • When using cross-schema table inheritance, only data from the selected schemas is shown. If using a table filter, only data is shown from the table and it's children. As one cannot yet use a table filter with multiple schema's, it's impossible to only show the table with it's cross-schema children (though RDFService should support this behaviour).

@svandenhoek svandenhoek marked this pull request as draft October 31, 2024 13:09
@svandenhoek svandenhoek changed the title chore(RDF): Fixed a bugged test fix(RDF): Output not always as expected when using table inheritance Oct 31, 2024
@svandenhoek svandenhoek marked this pull request as ready for review November 15, 2024 10:36
@svandenhoek svandenhoek merged commit 869d8a5 into master Nov 18, 2024
6 checks passed
@svandenhoek svandenhoek deleted the fix/rdf_table_inheritance branch November 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants