feat(admin): add backend role management api #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswertz
requested changes
Nov 13, 2024
.../molgenis-emx2-graphql/src/main/java/org/molgenis/emx2/graphql/GraphqlAdminFieldFactory.java
Show resolved
Hide resolved
| .field( | ||
| GraphQLFieldDefinition.newFieldDefinition() | ||
| .name(USERS) | ||
| .argument(GraphQLArgument.newArgument().name(EMAIL).type(Scalars.GraphQLString)) |
There was a problem hiding this comment.
I would prefer a 'search' argument so we can search in any field. I would for example like to search on role names. That might also be a future enhancement (I think we should first convert emx2 metadata schema to be a 'normal' schema).
...nd/molgenis-emx2-graphql/src/test/java/org/molgenis/emx2/graphql/TestGraphqlAdminFields.java
Outdated
Show resolved
Hide resolved
...nd/molgenis-emx2-graphql/src/test/java/org/molgenis/emx2/graphql/TestGraphqlAdminFields.java
Show resolved
Hide resolved
| assertEquals(TEST_PERSOON, anotherSchemaMember.getUser()); | ||
|
|
||
| // clean up | ||
| testDatabase.removeUser(TEST_PERSOON); |
There was a problem hiding this comment.
I would keep the schema, generally we don't cleanup schemas because it helps debugging.
There was a problem hiding this comment.
Changed it, but shouldn't unit test run in a vacuum? I kind of dislike that running the tests clogs up my database with schemas.
|
mswertz
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did:
how to test:
mutation updateUser($updateUser:InputUpdateUser) {updateUser(updateUser:$updateUser){status, message}}and an updated user as variable (see unit test for field you can update).todo: