Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auto-formatting #4503

Merged
merged 1 commit into from
Nov 18, 2024
Merged

chore: auto-formatting #4503

merged 1 commit into from
Nov 18, 2024

Conversation

svandenhoek
Copy link
Contributor

What are the main changes you did

  • Included formatting automatically done when building.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should re-evaluate the formatter

@svandenhoek svandenhoek merged commit e598f5b into master Nov 18, 2024
1 of 4 checks passed
@svandenhoek svandenhoek deleted the chore/auto_formatting branch November 18, 2024 12:33
@svandenhoek
Copy link
Contributor Author

@connoratrug agreed. While I haven't worked on the graphql code yet myself, I do gotta be honest that I do not have the pre-commit hook either because it really slows down making a commit (I simply make sure I always build once before merging though technically that's not a 100% guarantee as that's something that you could forget to do).

Maybe CI should simply fail if formatting detects needed changes or CI doing this automatically and adds a commit to the branch/master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants