Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reduce preview resource requirements #4507

Merged
merged 5 commits into from
Nov 21, 2024
Merged

build: reduce preview resource requirements #4507

merged 5 commits into from
Nov 21, 2024

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Nov 20, 2024

What are the main changes you did

  • reduce resource requirements because we are not using it

How to test

  • see preview still works

Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think a made a mistake in the unit ?

do you expect a (negative) impact time to ci/test completion ?

@mswertz
Copy link
Member Author

mswertz commented Nov 20, 2024

think a made a mistake in the unit ?

do you expect a (negative) impact time to ci/test completion ?

I hope to reduce scheduling time. However, we might need also CPU requirements because I suppose the difference in ci speeds is also due to difference in capacity (we might need more expensive nodes)

@mswertz mswertz merged commit 0847fc9 into master Nov 21, 2024
6 checks passed
@mswertz mswertz deleted the mswertz-patch-2 branch November 21, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants