Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catalogue): add profile for integrate cohorts #4515

Merged
merged 16 commits into from
Nov 28, 2024

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Nov 22, 2024

What are the main changes you did

  • add profile tags within data model files
  • add yaml file and template loader

How to test

  • in preview create new schema and choose 'INTEGRATE_COHORTS_STAGING template
  • see the attributes in the form of the Resources table
  • download data model and upload in test environment (data-catalogue-acc?) for testing by INTEGRATE team

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@BrendaHijmans BrendaHijmans marked this pull request as ready for review November 22, 2024 15:08
@BrendaHijmans BrendaHijmans self-assigned this Nov 22, 2024
Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik heb het schema proberen te maken op de preview, maar als ik een schema integrate maak en als template het integrate cohorts staging template kies dan zie ik wel dat er tabellen aangemaakt worden, maar het resulterende schema is leeg.

Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this is in line with what we discussed. Preview works again.
Some warnings about missing fields in demo data though.

@BrendaHijmans BrendaHijmans merged commit c4fbdd9 into master Nov 28, 2024
6 checks passed
@BrendaHijmans BrendaHijmans deleted the feat/integrate-profile branch November 28, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants