Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add quotes around jobId parameter #4521

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

dtroelofsprins
Copy link
Contributor

What are the main changes you did

  • added surrounding quotes around the jobId parameter in the Python EMX2 client documentation

How to test

  • check the docs
  • might start a job on a server with the job=${jobId} without quotes => get Syntax Error Invalid decimal literal Then start one including the quotes and see that these are really necessary!

Checklist

  • updated docs in case of new feature
  • [nvt] added/updated tests
  • [nvt] added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Member

@harmbrugge harmbrugge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to allow this, but it indeed only works with quotes

@harmbrugge harmbrugge merged commit e6b82dd into master Nov 27, 2024
6 checks passed
@harmbrugge harmbrugge deleted the fix-python-docs branch November 27, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants