Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(directory) add service to cart from service details page #4543

Merged
merged 3 commits into from
Dec 6, 2024
Merged

feat(directory) add service to cart from service details page #4543

merged 3 commits into from
Dec 6, 2024

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

  • Allow user to add / remove service from service details page

Closes #4540

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@connoratrug connoratrug linked an issue Dec 5, 2024 that may be closed by this pull request
feat(directory): Add service to cart from service details page #4540
Closed
@connoratrug connoratrug changed the title feat: directory add service to cart from service details page feat(directory) add service to cart from service details page Dec 5, 2024
esthervanenckevort
esthervanenckevort approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functionality which works. Needs a frontend developer to have a look at the code in detail, but the changes look sensible to me.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@connoratrug connoratrug merged commit fb363b0 into master Dec 6, 2024
7 checks passed
@connoratrug connoratrug deleted the 4540-featdirectory-add-service-to-cart-from-service-details-page branch December 6, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxPostema MaxPostema MaxPostema approved these changes

@esthervanenckevort esthervanenckevort esthervanenckevort approved these changes

@mswertz mswertz Awaiting requested review from mswertz

@chinook25 chinook25 Awaiting requested review from chinook25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(directory): Add service to cart from service details page
3 participants
@connoratrug @esthervanenckevort @MaxPostema