Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(directory): Add services to staging area template #4555

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

hslh
Copy link
Contributor

@hslh hslh commented Dec 11, 2024

What are the main changes you did

  • Add Services table to data model for staging areas
  • Add Services table to demo data for staging areas

How to test

  • Create a new schema, upload the molgenis.csv data model, see Services
  • Upload demo data to schema (zip CSVs), see Services table is filled

@hslh hslh requested a review from dtroelofsprins December 11, 2024 13:51
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, except from the capabilities column that needs to be removed from the Biobanks table in order to make the biobank_directory_staging work.

And thanks for the fixes in the ERIC molgenis.csv. I don't quite understand how that was missed in the original services PR...

data/biobank-directory/stagingArea/molgenis.csv Outdated Show resolved Hide resolved
@hslh hslh requested a review from dtroelofsprins December 13, 2024 09:16
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It turns out that capabilities column is still in the biobank demo data file
    image

  • Second thing: for staging tables, there is a validation on ID for all other tables, I would suggest to also add it to the services.

@hslh hslh requested a review from dtroelofsprins December 13, 2024 11:34
@hslh hslh merged commit 2abc93d into master Dec 13, 2024
7 checks passed
@hslh hslh deleted the fix/add-services-to-staging-area-template branch December 13, 2024 12:21
@hslh hslh changed the title Add services to staging area template fix(directory): Add services to staging area template Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants