-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont crash when loading biobanks fails #4563
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally it seems to work, someone else needs to review the frontend code.
One thing that might be useful is to add an option to clear all filters if it hangs during a query. (Example: Diagnosis available, match all, and start selecting entire chapters in ICD until this message pops up)
Doesn't the clear filters button stay visible (edit: it doesn't: suggest to have an new ticket for that story)? Also, I can't get it to hang the way you describe. On the test server it just executes the query. Even when I also start adding the orpha codes (though it takes a few seconds to execute and the app gets very slow). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
strongly ( but not blocking) suggest to add a test
Quality Gate passedIssues Measures |
What are the main changes you did
How to test
Checklist